From a3425de469d9307f50ad9064dd7bfb6e1eaf914f Mon Sep 17 00:00:00 2001 From: ochibani <11yzyv86j@relay.firefox.com> Date: Wed, 8 Jan 2025 16:26:23 +0200 Subject: [PATCH] fix mic record --- core/src/ffmpeg_windows.rs | 6 ++++-- gui/src/ui.rs | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/core/src/ffmpeg_windows.rs b/core/src/ffmpeg_windows.rs index c329983..031c39d 100644 --- a/core/src/ffmpeg_windows.rs +++ b/core/src/ffmpeg_windows.rs @@ -579,7 +579,9 @@ impl Ffmpeg { .to_string(); let mut ffmpeg_command = FfmpegCommand::new(); ffmpeg_command.format("dshow") - .input(format!("audio={}", &self.audio_input_id)) + .input(format!("audio=\"{}\"", &self.audio_input_id.active_text() + .ok_or_else(|| anyhow!("Failed to get audio input source."))?) + ) .format("ogg"); // Disable bitrate if value is zero if self.audio_record_bitrate.value() as u16 > 0 { @@ -612,7 +614,7 @@ impl Ffmpeg { .ok_or_else(|| anyhow!("Not exiting the input audio recording process successfully."))? .borrow_mut() .quit()?; - } + } Ok(()) } diff --git a/gui/src/ui.rs b/gui/src/ui.rs index 67f58d9..6dfca8b 100644 --- a/gui/src/ui.rs +++ b/gui/src/ui.rs @@ -210,6 +210,7 @@ fn build_ui(application: &Application, error_dialog: MessageDialog, error_messag #[cfg(any(target_os = "freebsd", target_os = "linux"))] let audio_output_source: String = audio_output_source().unwrap_or_else(|_| String::new()); + #[cfg(any(target_os = "freebsd", target_os = "linux"))] audio_source_combobox.append(Some("default"), &get_bundle("audio-input", None)); for (id, audio_source) in sources_descriptions.iter().enumerate() { audio_source_combobox.append(Some(id.to_string().as_str()), audio_source);